asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...
Date Sat, 14 Oct 2017 17:41:20 GMT
Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessibleOutputStream
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2073/2/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java:

PS2, Line 112: OutOfMemoryError
I'm not sure that we should throw Java's OOM here as that indicates that the JVM wasn't able
to allocate there memory (and thus the application maybe unstable as other threads might not
have enough memory as well and potentially corrupted state). 
In this case we see the problem before affecting other threads and so it seems that we could
just throw a regular exception here which will fail the job that caused the allocation, but
not affect other threads.
Does that make sense or do we want the OOM behavior?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message