asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luo Chen (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2121][HYR] Handle Throwables during job execution
Date Tue, 03 Oct 2017 22:31:02 GMT
Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2121][HYR] Handle Throwables during job execution
......................................................................


Patch Set 1:

> It is undesired to catch non-Exceptions, as they can be critical VM
 > conditions (such as out of memory).  Uncaught exceptions should be
 > handled by the uncaught exception handler, which attempts to log
 > the exception and shutdown the process.

Do we have such uncaught exception handler for Hyracks job threads?
The problem I found is that when a thread fails because of assertion errors,
the failure is saliently suppressed and ignored, which is undesirable for the debugging and
logging purposes. If we do not have one, maybe we can add it for logging purpose?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2051
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbe09d5231fe2bdfa12d834bb1a6adb46b355a48
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: No

Mime
View raw message