asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luo Chen (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2119][COMP] Fix variable ordering of project push...
Date Tue, 03 Oct 2017 16:10:17 GMT
Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2119][COMP] Fix variable ordering of project pushdown
......................................................................


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2048/3/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushProjectDownRule.java
File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushProjectDownRule.java:

Line 81:     private static Pair<Boolean, Boolean> pushThroughOp(Set<LogicalVariable>
toPush, Mutable<ILogicalOperator> opRef2,
> Reformating issue?
I think we changed the name of HashSet to Set, which makes the parameter names more compactable...


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2048
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21d0a2764e22482a9361b709e566d78acd33cf4d
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-HasComments: Yes

Mime
View raw message