Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AB2D1200CFC for ; Thu, 28 Sep 2017 20:15:35 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A9D731609CD; Thu, 28 Sep 2017 18:15:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F01851609B4 for ; Thu, 28 Sep 2017 20:15:34 +0200 (CEST) Received: (qmail 85115 invoked by uid 500); 28 Sep 2017 18:15:34 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 85063 invoked by uid 99); 28 Sep 2017 18:15:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Sep 2017 18:15:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BAAFC18117E for ; Thu, 28 Sep 2017 18:15:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id b5DA6fDc4AdB for ; Thu, 28 Sep 2017 18:15:31 +0000 (UTC) Received: from vitalstatistix.ics.uci.edu (vitalstatistix.ics.uci.edu [128.195.52.38]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4E3C85FD1B for ; Thu, 28 Sep 2017 18:15:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vitalstatistix.ics.uci.edu (Postfix) with ESMTP id D8A90100735; Thu, 28 Sep 2017 11:15:30 -0700 (PDT) Date: Thu, 28 Sep 2017 11:15:30 -0700 From: "Dmitry Lychagin (Code Review)" To: Taewoo Kim CC: Jenkins , Yingyi Bu Reply-To: dmitry.lychagin@couchbase.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required X-Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26 X-Gerrit-ChangeURL: X-Gerrit-Commit: 56aa23d33bd5bd12506a17e4a87f5639e378af2f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20170928181530.D8A90100735@vitalstatistix.ics.uci.edu> archived-at: Thu, 28 Sep 2017 18:15:35 -0000 Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required ...................................................................... Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2030/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java: Line 606: Pair> RootOpAndPKVars = It looks like there're no testcases in this review for changes in InvertedIndexAccessMethod. Can we move InvertedIndexAccessMethod changes into a separate review and add new tests for them there? The remaining changes (in IntroduceJoinAccessMethodRule) look good and can be merged. -- To view, visit https://asterix-gerrit.ics.uci.edu/2030 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes