asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ildar Absalyamov (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2114][MTD] Fixed incorrectly persisted FeedPolicy
Date Fri, 29 Sep 2017 23:25:41 GMT
Ildar Absalyamov has submitted this change and it was merged.

Change subject: [ASTERIXDB-2114][MTD] Fixed incorrectly persisted FeedPolicy
......................................................................


[ASTERIXDB-2114][MTD] Fixed incorrectly persisted FeedPolicy

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- New FeedPolicy was incorrectly persisting PolicyName & Description fields

Change-Id: I04beb24c861b116525a9da467fafc1742f4a73d4
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2035
Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Steven Jacobs <sjaco002@ucr.edu>
Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
---
M asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/create-policy-from-file/create-policy-from-file.1.adm
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FeedPolicyTupleTranslator.java
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Steven Jacobs: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified



diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/create-policy-from-file/create-policy-from-file.1.adm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/create-policy-from-file/create-policy-from-file.1.adm
index 7c4c53b..f006dcb 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/create-policy-from-file/create-policy-from-file.1.adm
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/create-policy-from-file/create-policy-from-file.1.adm
@@ -1 +1 @@
-{ "DataverseName": "experiments", "PolicyName": "someString", "Description": "experiments",
"Properties": {{ { "Name": "name", "Value": "testname" }, { "Name": "value", "Value": "testvalue"
}, { "Name": "key", "Value": "testkey" } }} }
+{ "DataverseName": "experiments", "PolicyName": "testPolicy", "Description": "someString",
"Properties": {{ { "Name": "name", "Value": "testname" }, { "Name": "value", "Value": "testvalue"
}, { "Name": "key", "Value": "testkey" } }} }
diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FeedPolicyTupleTranslator.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FeedPolicyTupleTranslator.java
index 8ddac7a..ec22735 100644
--- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FeedPolicyTupleTranslator.java
+++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FeedPolicyTupleTranslator.java
@@ -141,7 +141,7 @@
         fieldValue.reset();
         aString.setValue(feedPolicy.getDescription());
         stringSerde.serialize(aString, fieldValue.getDataOutput());
-        recordBuilder.addField(MetadataRecordTypes.FEED_POLICY_ARECORD_POLICY_NAME_FIELD_INDEX,
fieldValue);
+        recordBuilder.addField(MetadataRecordTypes.FEED_POLICY_ARECORD_DESCRIPTION_FIELD_INDEX,
fieldValue);
 
         // write field 3 (properties)
         Map<String, String> properties = feedPolicy.getProperties();

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2035
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04beb24c861b116525a9da467fafc1742f4a73d4
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>

Mime
View raw message