asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitry Lychagin (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Date Thu, 28 Sep 2017 18:15:30 GMT
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
......................................................................


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2030/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java:

Line 606:         Pair<ILogicalOperator, Set<LogicalVariable>> RootOpAndPKVars
=
It looks like there're no testcases in this review for changes in InvertedIndexAccessMethod.
Can we move InvertedIndexAccessMethod changes into a separate review and add new tests for
them there? 
The remaining changes (in IntroduceJoinAccessMethodRule) look good and can be merged.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-HasComments: Yes

Mime
View raw message