asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ildar Absalyamov (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup
Date Tue, 26 Sep 2017 18:11:54 GMT
Ildar Absalyamov has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
......................................................................


Patch Set 17:

(15 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponent.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponent.java:

PS17, Line 2: 
            :   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
            : 
> What happened here? Can we revert?
Sorry, that was poorly configured copyright properties in IDEA. FIxed


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponent.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponent.java:

PS17, Line 3:   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponentFactory.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponentFactory.java:

PS17, Line 3:   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponent.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponent.java:

PS17, Line 2: 
            :   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
            : 
> revert changes to the comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMWithBloomFilterDiskComponent.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMWithBloomFilterDiskComponent.java:

PS17, Line 2: 
            :   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
            : 
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMWithBuddyDiskComponent.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMWithBuddyDiskComponent.java:

PS17, Line 2: 
            :   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
            : 
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMWithBuddyMemoryComponent.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMWithBuddyMemoryComponent.java:

PS17, Line 2: 
            :   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
            : 
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java:

PS17, Line 3:   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java:

PS17, Line 3:   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/FilterBulkLoader.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/FilterBulkLoader.java:

PS17, Line 3:   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IChainedComponentBulkLoader.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IChainedComponentBulkLoader.java:

PS17, Line 3:   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IndexWithBuddyBulkLoader.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IndexWithBuddyBulkLoader.java:

PS17, Line 3:   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexBulkLoader.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexBulkLoader.java:

PS17, Line 3:   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexDiskComponentBulkLoader.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexDiskComponentBulkLoader.java:

PS17, Line 3:   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
> fix formatting of comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntimatterDiskComponent.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntimatterDiskComponent.java:

PS17, Line 3:   * Licensed to the Apache Software Foundation (ASF) under one
            :   * or more contributor license agreements.  See the NOTICE file
            :   * distributed with this work for additional information
            :   * regarding copyright ownership.  The ASF licenses this file
            :   * to you under the Apache License, Version 2.0 (the
            :   * "License"); you may not use this file except in compliance
            :   * with the License.  You may obtain a copy of the License at
            :   *
            :   *   http://www.apache.org/licenses/LICENSE-2.0
            :   *
            :   * Unless required by applicable law or agreed to in writing,
            :   * software distributed under the License is distributed on an
            :   * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            :   * KIND, either express or implied.  See the License for the
            :   * specific language governing permissions and limitations
            :   * under the License.
> fix formatting of comment?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Wail Alkowaileet <wael.y.k@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message