asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luo Chen (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2090][STO] Fix componentIds for bulk load
Date Thu, 21 Sep 2017 21:03:35 GMT
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/2015

to look at the new patch set (#3).

Change subject: [ASTERIXDB-2090][STO] Fix componentIds for bulk load
......................................................................

[ASTERIXDB-2090][STO] Fix componentIds for bulk load

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Currently we use LSN as component Ids during the flush time. However,
bulk loaded components receive no component Ids because of no
transactions on them. This patch is a temp fix for this bug by simply
giving bulk loaded components with id 0. This is correct since
currently we only allow load an empty dataset.

An alternative (and better) approach is to use the timestamp instead of
LSNs as component Ids. This needs some discussions, and might be
implemented later.

Change-Id: I3d85c1a0a2e9f04bac1c56113987aa48e1beafe2
---
M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java
1 file changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/15/2015/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2015
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d85c1a0a2e9f04bac1c56113987aa48e1beafe2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>

Mime
View raw message