asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup
Date Tue, 19 Sep 2017 16:37:22 GMT
Ian Maxon has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
......................................................................


Patch Set 16:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2014/16/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndex.java
File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndex.java:

PS16, Line 89: Purge the index files out of the buffer cache.
             :      * Can only be called if the caller is absolutely sure the files don't
contain dirty pages
             :      *
             :      * @throws HyracksDataException
             :      *             if the index is active
             :      */
             :     void purge() throws HyracksDataException;
             : 
             :     /**
I'm not really sure this should be in IIndex. Only an LSM index would ever really want this,
right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message