asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitry Lychagin (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
Date Mon, 18 Sep 2017 18:24:38 GMT
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
......................................................................


Patch Set 14:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1916/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java
File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java:

Line 146:         if (isPrimaryIndex || indexDataset.getDatasetType() == DatasetConfig.DatasetType.EXTERNAL
||
> Yes, we could put checks in "QueryTranslator.handleCreateIndexStatement" to
Sounds good. Let's do it


https://asterix-gerrit.ics.uci.edu/#/c/1916/14/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FixReplicateOperatorOutputsRule.java
File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FixReplicateOperatorOutputsRule.java:

Line 123:                 if (parentsPathToReplicate.contains(replicateOperator.getOutputs().get(oldParentIndex)))
{
> Yes, when replicate/split operators hold references to their outputs (i.e. 
yes, deleting and then assigning real parents would be better. As for 'outputMaterializationFlags',
may be for now we just have one boolean which would apply to all outputs. So the order in
which we reassign outputs would not matter. Eventually we should explore whether we can move
that 'materialization' property from the logical to the physical level, and see whether it
could be inferred automatically based on the topology of the physical plan. I've filed ASTERIXDB-2099
to track future work in this area.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman <ali.al.solaiman@gmail.com>
Gerrit-Reviewer: Ali Alsuliman <ali.al.solaiman@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message