asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [NO ISSUE][HYR][*DB][CLUS] Startup lifecycle fixes
Date Wed, 13 Sep 2017 18:28:42 GMT
Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][CLUS] Startup lifecycle fixes
......................................................................


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2004/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java:

PS3, Line 31: RECOVERING
> What's the difference between PENDING and RECOVERING? Maybe we could add co
The PENDING state is when all cluster partitions are active, and max resource IDs are reported,
but the metadata node has not yet been bound.  RECOVERING is after the metadata node has been
bound, before global recovery has completed.


https://asterix-gerrit.ics.uci.edu/#/c/2004/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/IApplication.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/IApplication.java:

PS3, Line 28: fixupThreadFactory
> This method does not seem to fit in well with the other ones. Why is the Th
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2004
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id30415325047008c013e305ca11ccbb76bc7d8d8
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message