asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Date Sun, 10 Sep 2017 22:36:24 GMT
Till Westmann has submitted this change and it was merged.

Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................


[ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Update docs to reflect the new enforcement of semicolon
  after every statement.
- Add missing semicolons to SET statements in examples.

Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1996
Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <tillw@apache.org>
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
2 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified

Objections:
  Anon. E. Moose #1000171: 



diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md b/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
index 99954f7..658190b 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
@@ -19,7 +19,7 @@
 
 # <a id="DDL_and_DML_statements">5. DDL and DML statements</a>
 
-    Statement ::= ( SingleStatement ( ";" )? )* <EOF>
+    Statement ::= ( ( SingleStatement )? ( ";" )+ )* <EOF>
     SingleStatement ::= DatabaseDeclaration
                       | FunctionDeclaration
                       | CreateStatement
@@ -28,7 +28,7 @@
                       | SetStatement
                       | InsertStatement
                       | DeleteStatement
-                      | Query ";"
+                      | Query
 
 In addition to queries, an implementation of SQL++ needs to support statements for data definition
 and manipulation purposes as well as controlling the context to be used in evaluating SQL++
expressions.
diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md b/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
index 9d42b00..1b392fe 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
@@ -44,7 +44,7 @@
 
 ##### Example
 
-    SET `compiler.parallelism` "16"
+    SET `compiler.parallelism` "16";
 
     SELECT u.name AS uname, m.message AS message
     FROM GleambookUsers u JOIN GleambookMessages m ON m.authorId = u.id;
@@ -71,7 +71,7 @@
 
 ##### Example
 
-    SET `compiler.groupmemory` "64MB"
+    SET `compiler.groupmemory` "64MB";
 
     SELECT msg.authorId, COUNT(*)
     FROM GleambookMessages msg
@@ -79,7 +79,7 @@
 
 ##### Example
 
-    SET `compiler.sortmemory` "67108864"
+    SET `compiler.sortmemory` "67108864";
 
     SELECT VALUE user
     FROM GleambookUsers AS user
@@ -87,7 +87,7 @@
 
 ##### Example
 
-    SET `compiler.joinmemory` "132000KB"
+    SET `compiler.joinmemory` "132000KB";
 
     SELECT u.name AS uname, m.message AS message
     FROM GleambookUsers u JOIN GleambookMessages m ON m.authorId = u.id;

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>

Mime
View raw message