asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ildar Absalyamov (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [STO][IDX] Eliminated excess antimatter in LSMBTree
Date Fri, 08 Sep 2017 01:35:19 GMT
Ildar Absalyamov has posted comments on this change.

Change subject: [STO][IDX] Eliminated excess antimatter in LSMBTree
......................................................................


Patch Set 15:

(9 comments)

Almost all the casts were eliminated by changing methods and classes to use index-specific
generic parameters.
The only exception is the code in BTree.java, which could not use BTree-specific interfaces
because it's also used to store RTree tuples in RTreeWithAntimatterTuples (see LSMRTreeUtils.java).

https://asterix-gerrit.ics.uci.edu/#/c/1538/10/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/FieldPrefixTupleReference.java
File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/FieldPrefixTupleReference.java:

PS10, Line 26: 
> If this is used only for BTree, rename it to reflect this.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1538/10/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/tuples/BTreeTypeAwareTupleWriter.java
File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/tuples/BTreeTypeAwareTupleWriter.java:

PS10, Line 36: T createTupleReference()
> Change the return type here to BTreeTypeAwareTupleWriter to avoid the downc
Eliminated by refactoring


https://asterix-gerrit.ics.uci.edu/#/c/1538/10/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IBTreeIndexTupleReference.java
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IBTreeIndexTupleReference.java:

PS10, Line 22: interface
> Add javadocs on each method
Done


https://asterix-gerrit.ics.uci.edu/#/c/1538/10/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IBTreeIndexTupleWriter.java
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IBTreeIndexTupleWriter.java:

PS10, Line 22: interface
> javadocs
Done


https://asterix-gerrit.ics.uci.edu/#/c/1538/10/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java:

PS10, Line 331: scanCursor.next();
              :                 // we can safely throw away updated tuples in secondary BTree
components, because they correspond to
              :                 /
> Can this be done in a better way where we pass false for updateAware in the
Done


https://asterix-gerrit.ics.uci.edu/#/c/1538/10/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java:

PS10, Line 61: 
             : 
             :     @Override
             :     protected int getNullFlagsBytes(int numFields) {
             :         // numFields + matter/antimatter bit +
> This is repeated in multiple places. It would be nice if it could be moved 
Done


PS10, Line 100: 
> This should be a constant.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1538/10/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java:

PS10, Line 67: elds, int[] filter
> Please use consistent naming for this flag.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1538/10/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/util/LSMBTreeTestContext.java
File hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/util/LSMBTreeTestContext.java:

PS10, Line 77: needKeyDu
> I don't think adding a parameter called isPrimary in Hyracks storage level 
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1538
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12a67eff8431b52d1f9051b793a5a64b15c009e9
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message