Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C683A200CDA for ; Fri, 4 Aug 2017 22:35:35 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C4B9D16E463; Fri, 4 Aug 2017 20:35:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1331B16E462 for ; Fri, 4 Aug 2017 22:35:34 +0200 (CEST) Received: (qmail 50152 invoked by uid 500); 4 Aug 2017 20:35:34 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 50143 invoked by uid 99); 4 Aug 2017 20:35:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2017 20:35:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C6731C023D for ; Fri, 4 Aug 2017 20:35:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.126 X-Spam-Level: ** X-Spam-Status: No, score=2.126 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id E932LLwvumZu for ; Fri, 4 Aug 2017 20:35:33 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6C18F60D17 for ; Fri, 4 Aug 2017 20:35:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id F206F241A02; Fri, 4 Aug 2017 13:35:24 -0700 (PDT) Date: Fri, 4 Aug 2017 13:35:24 -0700 From: "Murtadha Hubail (Code Review)" CC: Jenkins , Till Westmann , Michael Blow Reply-To: mhubail@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [ASTERIXDB-2019][CLUS] Update cluster state on partitions ch... X-Gerrit-Change-Id: I7d11733a1dcd86136e157d80517bff4abcfc776b X-Gerrit-ChangeURL: X-Gerrit-Commit: f01355d28c6e69ddb02d8ffa068ecae81baf56cb In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20170804203524.F206F241A02@unhygienix.ics.uci.edu> archived-at: Fri, 04 Aug 2017 20:35:36 -0000 Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2019][CLUS] Update cluster state on partitions changes ...................................................................... Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1918/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java: PS1, Line 377: TODO > Would https://issues.apache.org/jira/browse/ASTERIXDB-2021 address this TOD Yes, but ideally I think since this is on Asterix level, it should throw RuntimeDataException. I tried updating the API but it required touching so many classes. -- To view, visit https://asterix-gerrit.ics.uci.edu/1918 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d11733a1dcd86136e157d80517bff4abcfc776b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes