asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ASTERIXDB-2023) Introduce Enums instead of using bytes for ActiveEvents and Messages
Date Tue, 08 Aug 2017 11:46:00 GMT

    [ https://issues.apache.org/jira/browse/ASTERIXDB-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118224#comment-16118224
] 

ASF subversion and git services commented on ASTERIXDB-2023:
------------------------------------------------------------

Commit 07075667c39d1b44939dfb83389de2626b21d8b7 in asterixdb's branch refs/heads/master from
[~alamoudi]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=0707566 ]

[ASTERIXDB-2008][CLUS] Only add pending removal if node known

[ASTERIXDB-2023][ING] Introduce Enums instead of using bytes

- user model changes: no
- storage format changes: no
- interface changes: no

details:
- Only nodes which are known to cluster manager are added
to the list of nodes pending removal. Other nodes are ignored
- Enums introduced:
  - ActiveEvent.Kind
  - ActivePartitionMessage.Event
- Remove AdapterRuntimeManager
- Remove AdapterExecutor

Change-Id: I7044896559798426c04a3f46861bc5335b25d140
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1921
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <mhubail@apache.org>


> Introduce Enums instead of using bytes for ActiveEvents and Messages
> --------------------------------------------------------------------
>
>                 Key: ASTERIXDB-2023
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2023
>             Project: Apache AsterixDB
>          Issue Type: Bug
>          Components: ING - Ingestion
>            Reporter: Abdullah Alamoudi
>            Assignee: Abdullah Alamoudi
>
> Some classes such as ActiveEvent uses a byte member to indicates type. While this is
not incorrect, it introduces room for mistakes. In addition, logging becomes harder to follow
if the byte value is logged.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message