asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <>
Subject Change in asterixdb[master]: [ASTERIXDB-2058][HYR] Only Complete job cancellation after c...
Date Wed, 23 Aug 2017 22:15:15 GMT
abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2058][HYR] Only Complete job cancellation after cleanup

Patch Set 2:

File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/

PS5, Line 84: 
> should we create a better exception with code / message instead of just pro
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/

Line 141:                 new SessionConfig(format, true, true, true, ExecuteStatementRequestMessage.DEFAULT_JOB_TIMEOUT_MILLIS);
> I think the goal was to follow N1QL format for timeout to be API compatible
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/

PS5, Line 59: TimeUnit.MINUTES.toMillis(6);
> really?  65 minute default?   seems to be really high, and should be config
ops.. by mistake.

Fine. I will do the parameter thing now...

PS5, Line 60: S.toMillis(5);
> should be configurable
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/

PS5, Line 134: NullPointerException
> IllegalArgumentException?  I think this is what is used elsewhere for this.
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/

PS5, Line 21: DummyCallback
> this might make dumb people feel bad- can we call it NoOpCallback?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I14b4bbd512cc88e489254d8bf82edba0fd3a3db5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <>
Gerrit-Reviewer: Dmitry Lychagin <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Michael Blow <>
Gerrit-Reviewer: Michael Carey <>
Gerrit-Reviewer: Murtadha Hubail <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Xikui Wang <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message