asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2058][HYR] Only Complete job cancellation after c...
Date Wed, 23 Aug 2017 22:15:15 GMT
abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2058][HYR] Only Complete job cancellation after cleanup
......................................................................


Patch Set 2:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1961/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java:

PS5, Line 84: 
> should we create a better exception with code / message instead of just pro
Done


https://asterix-gerrit.ics.uci.edu/#/c/1961/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/NCQueryServiceServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/NCQueryServiceServlet.java:

Line 141:                 new SessionConfig(format, true, true, true, ExecuteStatementRequestMessage.DEFAULT_JOB_TIMEOUT_MILLIS);
> I think the goal was to follow N1QL format for timeout to be API compatible
Done


https://asterix-gerrit.ics.uci.edu/#/c/1961/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java:

PS5, Line 59: TimeUnit.MINUTES.toMillis(6);
> really?  65 minute default?   seems to be really high, and should be config
ops.. by mistake.

Fine. I will do the parameter thing now...


PS5, Line 60: S.toMillis(5);
> should be configurable
Done


https://asterix-gerrit.ics.uci.edu/#/c/1961/5/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java:

PS5, Line 134: NullPointerException
> IllegalArgumentException?  I think this is what is used elsewhere for this.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1961/5/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/DummyCallback.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/DummyCallback.java:

PS5, Line 21: DummyCallback
> this might make dumb people feel bad- can we call it NoOpCallback?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1961
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I14b4bbd512cc88e489254d8bf82edba0fd3a3db5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message