asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2025][STO] Fix Merge Lifecycle
Date Fri, 11 Aug 2017 17:11:10 GMT
Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2025][STO] Fix Merge Lifecycle
......................................................................


Patch Set 11:

PS, I don't think we need to synchronize on deletion by ourselves.

1.  Throwing an exception about deleting a non-existing file doesn't give a user additional
information, as long as we log deletion operations in the log.  With an exception on hands,
a user is still not able to find out where the file gets deleted in the first place.

2.  Simple solution (i.e., the OS has already serialized file deletion operations) is easier
to understand and maintain.  

3. If we add ROLL_BACK, there'll be one more thing to synchronize by ourselves.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I843de8b26c181205e43f4eabe22a7c43f3ebfcbc
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: No

Mime
View raw message