asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
Date Fri, 04 Aug 2017 21:08:49 GMT
Taewoo Kim has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
......................................................................


Patch Set 10:

(4 comments)

For the test cases, I will also keep the original cases so that we will be able to see those
test cases turn into the hash-join.

https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

PS10, Line 117: boolean updateEntireExprInfo)
> What does this parameter mean and why it is needed?
This parameter is needed not to fill out all information (access method type, variable, and
indexes for the given expression) for the given optimizable function expression. For the probe-tree,
we only need to set the field-type for the given expression, though.


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java:

PS10, Line 323: fillSubTreeIndexExprs(leftSubTree, analyzedAMs, context, false);
> Why do we need to map variables for the left sub tree?
This only sets the field-type for the probe-subtree.


PS10, Line 351: isNullFuncExpr
> isNullFuncExpr -> isMissingFuncExpr ?
Done


PS10, Line 400: boolean leftSubTreeInitialized = leftSubTree.initFromSubTree(joinOp.getInputs().get(0),
false);
> Still need to init the left sub tree?
Yes. We need to at least create a new blank subtree class and set the root operator for that.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message