asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-2019][CLUS] Update cluster state on partitions ch...
Date Fri, 04 Aug 2017 20:35:24 GMT
Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2019][CLUS] Update cluster state on partitions changes
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1918/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java:

PS1, Line 377: TODO
> Would https://issues.apache.org/jira/browse/ASTERIXDB-2021 address this TOD
Yes, but ideally I think since this is on Asterix level, it should throw RuntimeDataException.
I tried updating the API but it required touching so many classes.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1918
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d11733a1dcd86136e157d80517bff4abcfc776b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message