asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [ASTERIXDB-1992][ING] Suspend/Resume active entities
Date Wed, 26 Jul 2017 23:02:08 GMT
Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-1992][ING] Suspend/Resume active entities
......................................................................


Patch Set 23:

(11 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1875/23/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveRuntimeManager.java
File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveRuntimeManager.java:

PS23, Line 80: synchronized
remove sync


https://asterix-gerrit.ics.uci.edu/#/c/1875/23/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/InfiniteRetryPolicy.java
File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/InfiniteRetryPolicy.java:

Line 23:     private IActiveEntityEventsListener listener;
final


https://asterix-gerrit.ics.uci.edu/#/c/1875/23/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java:

PS23, Line 136: null
Instead of null, notify state change event


PS23, Line 180: setState
As discussed, the state shouldn't be set to stopping


PS23, Line 340: waitForState
Rename


PS23, Line 397: getDatasetName
dataverse


PS23, Line 469: f
rename


PS23, Line 483:  
list states


https://asterix-gerrit.ics.uci.edu/#/c/1875/23/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java:

PS23, Line 228: if (sourceDataset == null) {
              :                 // The dataset has already been dropped.
              :                 // In this case, we should drop the generated target dataset
files.
              :                 dropDatasetFiles(target, metadataProvider, hcc);
              :                 return;
              :             }
This shouldn't happen now that the locks are not released until the end


https://asterix-gerrit.ics.uci.edu/#/c/1875/23/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/metadata/LockList.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/metadata/LockList.java:

PS23, Line 34: LockList
Replace exceptions by codes


https://asterix-gerrit.ics.uci.edu/#/c/1875/23/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

PS23, Line 199: becase
because


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1875
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeac8c73e6bad39a13663b84a52121356e3c6b40
Gerrit-PatchSet: 23
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mhubail@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message