asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <>
Subject Change in asterixdb[master]: [ASTERIXDB-1992][ING] Suspend/Resume active entities
Date Wed, 26 Jul 2017 23:02:08 GMT
Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-1992][ING] Suspend/Resume active entities

Patch Set 23:

File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/

PS23, Line 80: synchronized
remove sync
File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/

Line 23:     private IActiveEntityEventsListener listener;
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/

PS23, Line 136: null
Instead of null, notify state change event

PS23, Line 180: setState
As discussed, the state shouldn't be set to stopping

PS23, Line 340: waitForState

PS23, Line 397: getDatasetName

PS23, Line 469: f

PS23, Line 483:  
list states
File asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/

PS23, Line 228: if (sourceDataset == null) {
              :                 // The dataset has already been dropped.
              :                 // In this case, we should drop the generated target dataset
              :                 dropDatasetFiles(target, metadataProvider, hcc);
              :                 return;
              :             }
This shouldn't happen now that the locks are not released until the end
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/metadata/

PS23, Line 34: LockList
Replace exceptions by codes
File asterixdb/asterix-common/src/main/resources/asx_errormsg/

PS23, Line 199: becase

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeac8c73e6bad39a13663b84a52121356e3c6b40
Gerrit-PatchSet: 23
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Murtadha Hubail <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Xikui Wang <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message