asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb-bad[master]: Separate Predistributed Jobs from other Active Jobs
Date Tue, 25 Jul 2017 22:12:21 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Separate Predistributed Jobs from other Active Jobs
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1894/1/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
File asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java:

PS1, Line 116: unregisterListener
> This is a new interface change? Should I wait after the main one is merged 
yes please. I just renamed to make it symmetric. register/unregister sounds better than register/remove


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1894
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18de53d55bcd2b423b9c8f4521fc8c3db1f432e1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message