Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Sat, 3 Jun 2017 04:48:04 +0000 (UTC)
From: "Yingyi Bu (JIRA)" <jira@apache.org>
To: notifications@asterixdb.incubator.apache.org
Message-ID: <JIRA.13077045.1496461070000.358556.1496465284075@Atlassian.JIRA>
In-Reply-To: <JIRA.13077045.1496461070000@Atlassian.JIRA>
References: <JIRA.13077045.1496461070000@Atlassian.JIRA> <JIRA.13077045.1496461070986@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ASTERIXDB-1929) Factor out isAntimatter from
 TupleWriter and TupleWriterFactory
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 03 Jun 2017 04:48:09 -0000


    [ https://issues.apache.org/jira/browse/ASTERIXDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035813#comment-16035813 ] 

Yingyi Bu commented on ASTERIXDB-1929:
--------------------------------------

OK, I see the point.  The current implementation makes some sense to me now.

Then, my only left concern is the usage of factory -- can we remove setAntimatter from the LSMTreeRefrencingTupleWriterFactory, and instead, only set/unset antimatter in the tuple writer ?

{noformat}
public class LSMTreeRefrencingTupleWriterFactory implements ITreeIndexTupleWriterFactory {
    private static final long serialVersionUID = 1L;

    private final ITreeIndexTupleWriterFactory factory;
    private transient ILSMTreeTupleWriter createdTupleWriter;

    public LSMTreeRefrencingTupleWriterFactory(ITreeIndexTupleWriterFactory factory) {
        this.factory = factory;
    }

    @Override
    public ITreeIndexTupleWriter createTupleWriter() {
        createdTupleWriter = (ILSMTreeTupleWriter) factory.createTupleWriter();
        return createdTupleWriter;
    }

    public void setAntimatter(boolean isAntimatter) {
        if (this.createdTupleWriter != null) {
            this.createdTupleWriter.setAntimatter(isAntimatter);
        }
    }
}
{noformat}


> Factor out isAntimatter from TupleWriter and TupleWriterFactory
> ---------------------------------------------------------------
>
>                 Key: ASTERIXDB-1929
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929
>             Project: Apache AsterixDB
>          Issue Type: Improvement
>          Components: Storage
>            Reporter: Yingyi Bu
>            Assignee: Chen Luo
>
> isAntimatter is a property of the tuple that we're writing, but not a property of the Writer.  Hence, we probably should remove setAntimatter(...) from the TupleWriter.
> Currently, for each tuple write operation, we need to call setAntimatter() in both TupleWriterFactory and TupleWriter.  This is painful and potentially buggy -- a XxxFactory typically is one per NC.
> Instead, we can add a parameter to write tuple method:
> public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) 
> ->
> public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, boolean isDelete)


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)