Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Tue, 27 Jun 2017 14:40:37 -0700
From: "Michael Blow (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Till Westmann <tillw@apache.org>
Reply-To: mblow@apache.org
Subject: Change in asterixdb[master]: [ASTERIXDB-1955][CLUS][RT] Refactor, Keep-Alive
In-Reply-To: <gerrit.1498367069893.Id75dd55861976390b1098a496ff2c0345c991389@asterix-gerrit.ics.uci.edu>
References: <gerrit.1498367069893.Id75dd55861976390b1098a496ff2c0345c991389@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
Message-Id: <20170627214037.736D9240902@unhygienix.ics.uci.edu>
archived-at: Tue, 27 Jun 2017 21:40:44 -0000

Michael Blow has posted comments on this change.

Change subject: [ASTERIXDB-1955][CLUS][RT] Refactor, Keep-Alive
......................................................................


Patch Set 4:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1855/3/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java
File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java:

PS3, Line 124: if (response.status() != HttpResponseStatus.UNAUTHORIZED) {
             :                 // since the request failed, we need to close the channel on complete
             :                 future.addListener(ChannelFutureListener.CLOSE);
             :             }
> what if keepAlive = false and response status = unauthorized?
Seems that this would be not any different than when response status = 200.


https://asterix-gerrit.ics.uci.edu/#/c/1855/3/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java:

PS3, Line 68: fullResponse.headers().remove(HttpHeaderNames.CONNECTION);
> This is something we didn't do before (removing the header). just make sure
We are not keeping alive (we are about to close the connection), so I think it is right, it may help eliminate EOFs and retries by the client since we prematurely close a Keep-Alive connection.  It's not clear to me why we need to close on failure anyway- but that can be addressed in the future.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1855
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id75dd55861976390b1098a496ff2c0345c991389
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes