Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1A1FC200CBB for ; Tue, 20 Jun 2017 06:32:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 18984160BE4; Tue, 20 Jun 2017 04:32:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 36A55160BE1 for ; Tue, 20 Jun 2017 06:32:42 +0200 (CEST) Received: (qmail 35347 invoked by uid 500); 20 Jun 2017 04:32:41 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 35338 invoked by uid 99); 20 Jun 2017 04:32:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jun 2017 04:32:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EF8A1C68CF for ; Tue, 20 Jun 2017 04:32:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.127 X-Spam-Level: ** X-Spam-Status: No, score=2.127 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2QZWdoohZJ75 for ; Tue, 20 Jun 2017 04:32:40 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B56155F2F1 for ; Tue, 20 Jun 2017 04:32:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 723082420AE; Mon, 19 Jun 2017 21:32:39 -0700 (PDT) Date: Mon, 19 Jun 2017 21:32:39 -0700 From: "Luo Chen (Code Review)" CC: Jenkins , Ian Maxon , Till Westmann , abdullah alamoudi , Jianfeng Jia , Yingyi Bu Reply-To: cluo8@uci.edu X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [ASTERIXDB-1946][STO][IDX] Create BTreeIndex for Correlated ... X-Gerrit-Change-Id: I2a3435e6720f07bd6a5092d4d9ce42e8d4b7894c X-Gerrit-ChangeURL: X-Gerrit-Commit: ea5f65dd276176b9db2f7f7ca6f3bc05ebd8bf7f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20170620043239.723082420AE@unhygienix.ics.uci.edu> archived-at: Tue, 20 Jun 2017 04:32:43 -0000 Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-1946][STO][IDX] Create BTreeIndex for Correlated Datasets ...................................................................... Patch Set 15: (13 comments) > (19 comments) https://asterix-gerrit.ics.uci.edu/#/c/1813/14/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/scan-delete-btree-correlated-secondary-index-open/scan-delete-btree-correlated-secondary-index-open.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/scan-delete-btree-correlated-secondary-index-open/scan-delete-btree-correlated-secondary-index-open.1.ddl.sqlpp: PS14, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1813/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/scan-delete-btree-correlated-secondary-index-open/scan-delete-btree-correlated-secondary-index-open.2.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/scan-delete-btree-correlated-secondary-index-open/scan-delete-btree-correlated-secondary-index-open.2.update.sqlpp: PS12, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1813/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/scan-delete-btree-correlated-secondary-index-open/scan-delete-btree-correlated-secondary-index-open.4.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/scan-delete-btree-correlated-secondary-index-open/scan-delete-btree-correlated-secondary-index-open.4.query.sqlpp: PS12, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1813/14/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/scan-delete-btree-correlated-secondary-index-open/scan-delete-btree-correlated-secondary-index-open.4.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/scan-delete-btree-correlated-secondary-index-open/scan-delete-btree-correlated-secondary-index-open.4.query.sqlpp: PS14, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1813/14/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_correlated_secondary_index/primary_plus_default_correlated_secondary_index.2.ddl.aql File asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_correlated_secondary_index/primary_plus_default_correlated_secondary_index.2.ddl.aql: PS14, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1813/14/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_correlated_secondary_index/primary_plus_default_correlated_secondary_index.4.txneu.aql File asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_correlated_secondary_index/primary_plus_default_correlated_secondary_index.4.txneu.aql: PS14, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1813/14/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_correlated_secondary_index/primary_plus_default_correlated_secondary_index.5.ddl.aql File asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_correlated_secondary_index/primary_plus_default_correlated_secondary_index.5.ddl.aql: PS14, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1813/14/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_correlated_secondary_index/primary_plus_default_correlated_secondary_index.6.txnqbc.aql File asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_correlated_secondary_index/primary_plus_default_correlated_secondary_index.6.txnqbc.aql: PS14, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1813/14/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_correlated_secondary_index/primary_plus_default_correlated_secondary_index.9.txnqar.aql File asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_correlated_secondary_index/primary_plus_default_correlated_secondary_index.9.txnqar.aql: PS14, Line 21: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/1813/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryCreationTupleProcessorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryCreationTupleProcessorNodePushable.java: PS11, Line 71: > SecondaryIndex Done https://asterix-gerrit.ics.uci.edu/#/c/1813/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryCreationTupleProcessorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryCreationTupleProcessorNodePushable.java: PS14, Line 83: : : : : : : : : : : : : : : : > How is partition captured in this class? I fixed this by adding "partition" to the constructor. Since the job only has one shared object (which is this DeleteTupleCounter), I used partition as the id for this shared object. PS14, Line 119: > The state is one per job per node, but /LSMSecondaryCreationTupleProcessorN This was incorrect... This counter is supposed to be per partition per job per node. I fixed this by explicitly adding "partition" to the constructor. PS14, Line 231: > It looks that deletedTupleCounter is shared among different partitions on a It shouldn't be shared. Fixed. -- To view, visit https://asterix-gerrit.ics.uci.edu/1813 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a3435e6720f07bd6a5092d4d9ce42e8d4b7894c Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes