Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 94A07200CA8 for ; Thu, 1 Jun 2017 02:19:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 91BE5160BDB; Thu, 1 Jun 2017 00:19:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D95D0160BCB for ; Thu, 1 Jun 2017 02:19:09 +0200 (CEST) Received: (qmail 3208 invoked by uid 500); 1 Jun 2017 00:19:09 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 3197 invoked by uid 99); 1 Jun 2017 00:19:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Jun 2017 00:19:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AADEDC0EEE for ; Thu, 1 Jun 2017 00:19:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 0xf4Q8cGI6Fk for ; Thu, 1 Jun 2017 00:19:08 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A948D5F5B4 for ; Thu, 1 Jun 2017 00:19:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 5EEA52420C7; Wed, 31 May 2017 17:19:07 -0700 (PDT) Date: Wed, 31 May 2017 17:19:07 -0700 From: "Murtadha Hubail (Code Review)" To: Michael Blow CC: Jenkins , Till Westmann , Yingyi Bu Reply-To: hubailmor@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Enable Adding Nodes to Running *DB Cluster X-Gerrit-Change-Id: If978442a95687c00ef78c89ed1b4440f5e308b99 X-Gerrit-ChangeURL: X-Gerrit-Commit: e56eb07fde23db2e8eb36a0737049f018b33c074 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20170601001907.5EEA52420C7@unhygienix.ics.uci.edu> archived-at: Thu, 01 Jun 2017 00:19:10 -0000 Murtadha Hubail has posted comments on this change. Change subject: Enable Adding Nodes to Running *DB Cluster ...................................................................... Patch Set 8: Code-Review+2 I believe my question regarding restarting the instance after adding a node will be handled by an extension to persist the information about the newly added nodes. Other than that, LGTM. -- To view, visit https://asterix-gerrit.ics.uci.edu/1785 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If978442a95687c00ef78c89ed1b4440f5e308b99 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No