asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <>
Subject Change in asterixdb[master]: [ASTERIXDB-1955][CLUS][RT] Refactor, Keep-Alive
Date Tue, 27 Jun 2017 21:40:37 GMT
Michael Blow has posted comments on this change.

Change subject: [ASTERIXDB-1955][CLUS][RT] Refactor, Keep-Alive

Patch Set 4:

File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/

PS3, Line 124: if (response.status() != HttpResponseStatus.UNAUTHORIZED) {
             :                 // since the request failed, we need to close the channel on
             :                 future.addListener(ChannelFutureListener.CLOSE);
             :             }
> what if keepAlive = false and response status = unauthorized?
Seems that this would be not any different than when response status = 200.
File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/

PS3, Line 68: fullResponse.headers().remove(HttpHeaderNames.CONNECTION);
> This is something we didn't do before (removing the header). just make sure
We are not keeping alive (we are about to close the connection), so I think it is right, it
may help eliminate EOFs and retries by the client since we prematurely close a Keep-Alive
connection.  It's not clear to me why we need to close on failure anyway- but that can be
addressed in the future.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Id75dd55861976390b1098a496ff2c0345c991389
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Michael Blow <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message