asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: [CLUS][MTD] += ClusterStateManager pending removal
Date Thu, 22 Jun 2017 13:14:00 GMT
Murtadha Hubail has posted comments on this change.

Change subject: [CLUS][MTD] += ClusterStateManager pending removal
......................................................................


Patch Set 1:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1844/1//COMMIT_MSG
Commit Message:

Line 7: [CLUS][MTD] += ClusterStateManager pending removal
> Is there a new requirement to have JIRA issues for all changes?
According to the latest proposal, yes. At least the way I understood it and what others have
been doing since.


https://asterix-gerrit.ics.uci.edu/#/c/1844/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java:

PS1, Line 235: getParticipantNodes
> >> I think eventually all existing usages will have to use the excludePendi
Which state of the cluster? with all nodes or excluding the ones pending removal?
My suggestion was based on the assumption that you didn't want to impact the existing usages
and that's why I proposed passing false, but I think they all should exclude the ones pending
removal except for special cases in which you need to do an operation on a node pending removal.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1844
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I509a7eed727be1e339c1b75b75f778fd222cc0e2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message