asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Cleanup Buffer Cache
Date Fri, 16 Jun 2017 20:31:40 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Cleanup Buffer Cache
......................................................................


Patch Set 7:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1840/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/FileMapManager.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/FileMapManager.java:

PS7, Line 65: synchronized
> Why's this need to be synchronized, because of the action on both name2Id &
yes.


https://asterix-gerrit.ics.uci.edu/#/c/1840/7/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java:

PS7, Line 368:  // doesn't make sense since this is for all the files in the vbc. not for
just the file
> Wait, what?
oh oh. This was about the old implementation. I had the comment and commented the old implementation.

It just didn't make any sense because a vbc has "virtual" files for all the memory components
of the datasets. the previous implementation returns the collective size.

Will remove the comment. maybe it should return -1 or throw an exception.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1840
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15565b07afdc94ac74c608bfe4480fa09dcf8f1c
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message