asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Re-register NC with CC on reestablished IPCHandle
Date Tue, 13 Jun 2017 23:25:57 GMT
Till Westmann has posted comments on this change.

Change subject: Re-register NC with CC on reestablished IPCHandle
......................................................................


Patch Set 7:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1830/7/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/NCServiceExecutionIT.java
File asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/NCServiceExecutionIT.java:

PS7, Line 212: waitForCluster
Can we make this more generally accessible/reusable?


PS7, Line 268: waitForCluster
Move this before the nc.start()?


https://asterix-gerrit.ics.uci.edu/#/c/1830/7/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/INodeControllerService.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/INodeControllerService.java:

PS7, Line 23: INodeControllerService
Can we avoid this intermediate interface?


https://asterix-gerrit.ics.uci.edu/#/c/1830/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java:

PS7, Line 138: JobIdFactory
Empty line before?


https://asterix-gerrit.ics.uci.edu/#/c/1830/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NodeRegistration.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NodeRegistration.java:

PS7, Line 76: AtomicLong
Can we make this immutable?


https://asterix-gerrit.ics.uci.edu/#/c/1830/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java:

PS7, Line 177: ()));
Add nl?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1830
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f93ca9ab37e56e02bafcdecd1e2d0cf664faef6
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message