asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <>
Subject Change in asterixdb[master]: Log filter values for redo during recovery
Date Thu, 08 Jun 2017 22:02:07 GMT
Ian Maxon has posted comments on this change.

Change subject: Log filter values for redo during recovery

Patch Set 5:

File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/

Line 85:             if (allFields != null) {
> What does this if do? (allFields != null)
It implies that the filter value is not null, and hence you need to provide the filtering
fields to the accessor.
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/

Line 63:             allFields = new int[treeFields.length + filterFields.length];
> Can we put some comments on this? What does this do?
Sure. This is to get the fields for the complete tuple that will be given through insert.
This way we can construct a tuple reference within the optracker that can hold on to the incoming
tuple while the BTree itself works with the indexTuple, and then log it when appropriate rather
than the indexTuple.
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/

Line 178:     public IIndexAccessor createAccessor(IModificationOperationCallback modificationCallback,
> Can we take care of this?
It would not conform the the interface. I don't know why sonarqube complains.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Jianfeng Jia <>
Gerrit-Reviewer: Luo Chen <>
Gerrit-Reviewer: Michael Blow <>
Gerrit-Reviewer: Taewoo Kim <>
Gerrit-HasComments: Yes

View raw message