asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <>
Subject Change in asterixdb[master]: Log filter values for redo during recovery
Date Thu, 08 Jun 2017 17:26:15 GMT
Taewoo Kim has posted comments on this change.

Change subject: Log filter values for redo during recovery

Patch Set 5:


Thanks! A few thoughts
File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/

Line 1249:     }
Which would be the most frequent case? non-filter case? If so, can we change the order of
this if?
File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/

Line 59:     private PermutingTupleReference logTuple;
Can we put some comments on this for the future references?
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/

Line 85:             if (allFields != null) {
What does this if do? (allFields != null)
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/

Line 63:             allFields = new int[treeFields.length + filterFields.length];
Can we put some comments on this? What does this do?
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/

Line 60:             if (allFields != null) {
Maybe the same question here: what does this if do? (allFields != null)
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/

Line 178:     public IIndexAccessor createAccessor(IModificationOperationCallback modificationCallback,
> MAJOR SonarQube violation:
Can we take care of this?
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/

Line 64:             if (allFields != null) {
The same question here about allFields != null

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Jianfeng Jia <>
Gerrit-Reviewer: Luo Chen <>
Gerrit-Reviewer: Michael Blow <>
Gerrit-Reviewer: Taewoo Kim <>
Gerrit-HasComments: Yes

View raw message