asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Date Sat, 03 Jun 2017 00:53:25 GMT
Yingyi Bu has posted comments on this change.

Change subject: Allow insert anti-matter tuples when bulk loading LSM index
......................................................................


Patch Set 6:

(1 comment)

So my major concern is that "antimatter" should be factored out from TupleWriter/TupleWriterFactory.

https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java:

PS6, Line 119: updateFilter
> I think it has to. You have to search for the antimatter just as you would 
OK, got it!


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1796
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message