Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 06638200CA4 for ; Wed, 24 May 2017 01:05:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 035DF160BD3; Tue, 23 May 2017 23:05:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 49E30160BC3 for ; Wed, 24 May 2017 01:05:48 +0200 (CEST) Received: (qmail 56801 invoked by uid 500); 23 May 2017 23:05:47 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 56792 invoked by uid 99); 23 May 2017 23:05:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2017 23:05:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 233BE18FC88 for ; Tue, 23 May 2017 23:05:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id LoH9F3iqlhCD for ; Tue, 23 May 2017 23:05:46 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C59815F523 for ; Tue, 23 May 2017 23:05:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 3DCA4241D38; Tue, 23 May 2017 16:05:45 -0700 (PDT) Date: Tue, 23 May 2017 16:05:45 -0700 From: "abdullah alamoudi (Code Review)" To: Luo Chen CC: Ian Maxon , Yingyi Bu , Murtadha Hubail , Jenkins Reply-To: bamousaa@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: ASTERIXDB-1917: FLUSH_LSN for disk components is not correct... X-Gerrit-Change-Id: If438e34f8f612458d81f618eea04c0c72c49a9fe X-Gerrit-ChangeURL: X-Gerrit-Commit: 62f9777f5ea6a3c52fa04033e018e330994b3260 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20170523230545.3DCA4241D38@unhygienix.ics.uci.edu> archived-at: Tue, 23 May 2017 23:05:49 -0000 abdullah alamoudi has posted comments on this change. Change subject: ASTERIXDB-1917: FLUSH_LSN for disk components is not correctly set ...................................................................... Patch Set 1: Editing my comment since it didn't make sense: This is a great catch. I suggest we do the fix in some other way though. what we should do is in the ILSMIndex.scheduleFlush(ILSMIndexOperationContext ctx, ILSMIOOperationCallback callback), we put the lsn into the memory component's metadata. This way, we don't need to put the lsn after the flush operation in a special code. It will be treated just like any other metadata that is being copied into the new disk component. -- To view, visit https://asterix-gerrit.ics.uci.edu/1771 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If438e34f8f612458d81f618eea04c0c72c49a9fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No