Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Tue, 23 May 2017 00:19:31 -0700
From: "abdullah alamoudi (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
To: Michael Blow <mblow@apache.org>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	Ian Maxon <imaxon@apache.org>,
	Jianfeng Jia <jianfeng.jia@gmail.com>,
	Murtadha Hubail <hubailmor@gmail.com>,
	Yingyi Bu <buyingyi@gmail.com>
Reply-To: bamousaa@gmail.com
Subject: Change in asterixdb[master]: Fix upsert deadlock and upsert with filtered primary only bug
In-Reply-To: <gerrit.1495061772923.Ic702d6e1984ea33408c360b6f522f493848cbd87@asterix-gerrit.ics.uci.edu>
References: <gerrit.1495061772923.Ic702d6e1984ea33408c360b6f522f493848cbd87@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
Message-Id: <20170523071931.914C6240F4D@unhygienix.ics.uci.edu>
archived-at: Tue, 23 May 2017 07:19:35 -0000

abdullah alamoudi has posted comments on this change.

Change subject: Fix upsert deadlock and upsert with filtered primary only bug
......................................................................


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1759/3/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java:

PS3, Line 205: (
> I remember that we discussed before that enter/exit are details that each o
I think exposing it is a good idea.
First, it will enable one time enter and exist per frame rather than entering and exiting per record.
Second, it allows a record level operation not to start before it knows it entered the components it needs to.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1759
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic702d6e1984ea33408c360b6f522f493848cbd87
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes