Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B6B23200C72 for ; Fri, 12 May 2017 18:59:44 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B53B6160BB8; Fri, 12 May 2017 16:59:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06F25160BA8 for ; Fri, 12 May 2017 18:59:43 +0200 (CEST) Received: (qmail 97051 invoked by uid 500); 12 May 2017 16:59:43 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 97042 invoked by uid 99); 12 May 2017 16:59:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 May 2017 16:59:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DAF60C0B7D for ; Fri, 12 May 2017 16:59:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.127 X-Spam-Level: ** X-Spam-Status: No, score=2.127 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id i23l-RmFz9_7 for ; Fri, 12 May 2017 16:59:42 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id AD35B5F4EE for ; Fri, 12 May 2017 16:59:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 2562D2420E8; Fri, 12 May 2017 09:59:41 -0700 (PDT) Date: Fri, 12 May 2017 09:59:41 -0700 From: "abdullah alamoudi (Code Review)" CC: Yingyi Bu , Jenkins Reply-To: bamousaa@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Rename type check methods into meaningful names X-Gerrit-Change-Id: I35e5ed919aff2c374be1fbbb00ad7a752916a3dc X-Gerrit-ChangeURL: X-Gerrit-Commit: 011e30c1a56fef49933aaca4ae19bf827ea7f5e8 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20170512165941.2562D2420E8@unhygienix.ics.uci.edu> archived-at: Fri, 12 May 2017 16:59:44 -0000 abdullah alamoudi has posted comments on this change. Change subject: Rename type check methods into meaningful names ...................................................................... Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1735/6/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/CancellationTestExecutor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/CancellationTestExecutor.java: PS6, Line 109: } > You have to wait 20 seconds before moving to the next query. The cancellat I think that is already in executeQueryService of this class and I figured out what why this failed. -- To view, visit https://asterix-gerrit.ics.uci.edu/1735 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35e5ed919aff2c374be1fbbb00ad7a752916a3dc Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes