asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Change IO directory for integration util to be a directory i...
Date Wed, 31 May 2017 05:13:01 GMT
Michael Blow has posted comments on this change.

Change subject: Change IO directory for integration util to be a directory in target
......................................................................


Patch Set 6:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1789/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java:

PS6, Line 75: System.setProperty(ControllerConfig.TMP_DIR, getDefaultStoragePath())
this shouldn't be needed, you are setting the DEFAULT_DIR below.


PS6, Line 136: joinPath(System.getProperty(ControllerConfig.TMP_DIR)
use getDefaultStoragePath() here, then there's no reason to set java.io.tmpdir


PS6, Line 173: System.getProperty(ControllerConfig.TMP_DIR)
getDefaultStoragePath()


https://asterix-gerrit.ics.uci.edu/#/c/1789/6/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java:

PS6, Line 35: public static final String TMP_DIR = "java.io.tmpdir"
What's the advantage of making this a constant?  The JDK code seems to inline this reference
everywhere...  If we really want a constant, I think it should be in some generic helper/util
class and be named JAVA_IO_TMPDIR for clarity.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1789
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfb74dd4228725fb624eb1d21f621b7855f3d37
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message