asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ildar Absalyamov (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fixed race condition during ncMap lookup
Date Tue, 30 May 2017 19:56:29 GMT
Ildar Absalyamov has posted comments on this change.

Change subject: Fixed race condition during ncMap lookup
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1792/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/NodeResolver.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/NodeResolver.java:

PS1, Line 42: ncMap
> We don't need ncMap, ncs, nor random as static variables?  In this way, res
I believe this was done because resolving hostname is potentially a very expensive operation,
which can block calling thread for seconds.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1792
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bfbe712c100f48011a516c373ac8994028dc3dd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message