asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luo Chen (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add LSMDiskComponentBulkLoader
Date Fri, 26 May 2017 16:52:38 GMT
Luo Chen has posted comments on this change.

Change subject: Add LSMDiskComponentBulkLoader
......................................................................


Patch Set 4:

> I'm not sure I understand. The differences between IIndexBulkLoader
 > and ILSMDiskComponentBulkLoader seem to be all in the
 > implementation and not in the interface. So reusing/deriving from
 > the existing Hyracks interface in AsterixDB seems to be a good
 > idea.

Though they have the same methods, the meaning for them is different. ILSMDiskComponentBulkLoader
is used to bulk load a disk component, instead of a whole index (a disk component maybe shouldn't
be called as an index?).

If look at the code for flush and merge operations for LSMBTree/RTree/RTreeWithAntiMatterTuples/InvertedIndex,
the basic structure is quite similar, and we are bulk loading a disk component (with anti-matter
tuples or with deleted-btree). Without this LSMDiskComponentBulkLoader, then for each LSMIndex,
we have to write different code to bulk load its corresponding disk component. ILSMDiskComponentBulkLoader
(and its subinterface ILSMDiskComponentWithBuddyBTreeBulkLoader) provides a unified method
to bulk load lsm disk components (since we currently only have two kinds of disk component)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1773
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I772a6d68761fcbb85982a1c9f72f2d186e1d1ffb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: No

Mime
View raw message