asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1917: FLUSH_LSN for disk components is not correct...
Date Tue, 23 May 2017 23:05:45 GMT
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1917: FLUSH_LSN for disk components is not correctly set
......................................................................


Patch Set 1:

Editing my comment since it didn't make sense:

This is a great catch. I suggest we do the fix in some other way though.
what we should do is in the ILSMIndex.scheduleFlush(ILSMIndexOperationContext ctx, ILSMIOOperationCallback
callback), we put the lsn into the memory component's metadata.
This way, we don't need to put the lsn after the flush operation in a special code. It will
be treated just like any other metadata that is being copied into the new disk component.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If438e34f8f612458d81f618eea04c0c72c49a9fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <cluo8@uci.edu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: No

Mime
View raw message