asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luo Chen (Code Review)" <>
Subject Change in asterixdb[master]: Implemented Disk Components Alignment Based on IDs
Date Sat, 20 May 2017 06:15:27 GMT
Luo Chen has posted comments on this change.

Change subject: Implemented Disk Components Alignment Based on IDs

Patch Set 5:


 > A few questions
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/

PS4, Line 105:          * case 1.
             :          * if merga
> Can there be a toplevel comment describing what case 1/2/3 are?

PS4, Line 180:          totalSize += componentSize;
> Why call this with a set of indices, and the partition, and filter out the 
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/

PS4, Line 114: g id = getComponentLSN(null);
> Wait, what? Why getComonentLSN of a null value?
If oldComponents == null, then getComponentLSN would treat it as a flush operation, and return
the LSN for the flushed component. I added some comments for this.
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/

PS4, Line 108:     //TODO: do we need to throw an exception when ID is not found?
> If you can make it so that it fails safely that would be good. This way the
Currently, if a disk component is formed by flushing, then its componentID should be set.
However, one exception is that for bulk-loaded components, such as those created by loading
a dataset, the componentID is currently missing. If this happens, AbstractLSMIOOperationCallback
would log it.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I768ee9ac0a8d3c99c631086093a6b778b2e7588e
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Jianfeng Jia <>
Gerrit-Reviewer: Luo Chen <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message