asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <>
Subject Change in asterixdb[master]: Implemented Disk Components Alignment Based on IDs
Date Sat, 20 May 2017 00:08:11 GMT
Ian Maxon has posted comments on this change.

Change subject: Implemented Disk Components Alignment Based on IDs

Patch Set 4:


A few questions
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/

PS4, Line 105: 
             :         // [case 1]
Can there be a toplevel comment describing what case 1/2/3 are?

PS4, Line 180:  private void triggerScheduledMerge(long minID, long maxID, int partition,
Set<IndexInfo> indexInfos)
Why call this with a set of indices, and the partition, and filter out the indices which don't
apply from the merge, rather than only populating indexInfos with those that are relevant?
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/

PS4, Line 114:  long id = getComponentLSN(oldComponents);
Wait, what? Why getComonentLSN of a null value?
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/

PS4, Line 108:     //TODO: do we need to throw an exception when ID is not found?
If you can make it so that it fails safely that would be good. This way the metadata change
will be non-breaking.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I768ee9ac0a8d3c99c631086093a6b778b2e7588e
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Jianfeng Jia <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message