asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitry Lychagin (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Added built-in functions: ifmissing(), ifnull(), ifmissingor...
Date Wed, 17 May 2017 21:15:12 GMT
Dmitry Lychagin has posted comments on this change.

Change subject: Added built-in functions: ifmissing(), ifnull(), ifmissingornull()
......................................................................


Patch Set 4:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1745/3/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
File asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md:

PS3, Line 22: if_null
> Add an example to each function as other functions?
yes, I've added examples in the new patch


https://asterix-gerrit.ics.uci.edu/#/c/1745/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/IfMissingOrNullTypeComputer.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/IfMissingOrNullTypeComputer.java:

PS3, Line 55:  
> case ANY can be merged to "default:" ?
yes. merged in the new version


PS3, Line 59:                     
> Is the ANY/UNION case covered by the added tests?
'union' is covered by switch-case. 'any' has been merged into default, so I think we're ok
now.


PS3, Line 114: esultTypeComputer IF_MIS
> Follow the error message guideline and use error code?
yes. done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1745
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id114f6654b9814c5aeca07fffeea04daeb8dca19
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lychagin@couchbase.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message