asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Enable job compilation for variables that will be created at...
Date Fri, 12 May 2017 00:58:49 GMT
Yingyi Bu has posted comments on this change.

Change subject: Enable job compilation for variables that will be created at runtime
......................................................................


Patch Set 8:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1722/8//COMMIT_MSG
Commit Message:

PS8, Line 9: Runtime Context Variables
job parameters


https://asterix-gerrit.ics.uci.edu/#/c/1722/8/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobParameterByteStore.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobParameterByteStore.java:

PS8, Line 45: getParameterValue
How about thread safety?  For example, if you have concurrent requests for the same job with
different parameters, it will override each other?


In general, we should make pre-distributed job work for concurrent requests with different
parameters.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1722
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66ed97d9c25cb64afc8ac38d6675211cf76d97b
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message