asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Enable job compilation for variables that will be created at...
Date Thu, 11 May 2017 01:48:59 GMT
Till Westmann has posted comments on this change.

Change subject: Enable job compilation for variables that will be created at runtime
......................................................................


Patch Set 7:

I think that the change generally looks good. But I do have one
question/request:
Could we use "job parameter" (or "job param") instead of "runtime context
variable"? This would align nicely with the "JobFlags" and it would make
sense as a parameter to e.g. "startJob". Method parameters like
"contextRuntTimeVarMap" could be called "jobParameters" (or "jobParams").
Unless it’s semantically incorrect, I think that we should do such a change
at least for the Hyracks part of the change.
For the AsterixDB function, we can decide if we want to keep that the way it
is or rename that as well.
What do you think? (I would also do the change.)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1722
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66ed97d9c25cb64afc8ac38d6675211cf76d97b
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: No

Mime
View raw message