asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Make query plans more user-friendly.
Date Tue, 09 May 2017 20:01:55 GMT
Yingyi Bu has posted comments on this change.

Change subject: Make query plans more user-friendly.
......................................................................


Patch Set 15:

(9 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1721/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SimilarityCheckRule.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SimilarityCheckRule.java:

Line 205:             // Replace expr corresponding to original variable in the original assign
with a get-item on
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1721/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TranslationContext.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TranslationContext.java:

Line 36:     /** The stack is the used to manage the scope of variables for group-by rebindings.
*/
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1721/14/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TranslationContext.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TranslationContext.java:

PS14, Line 81: Expression
> Why not require a VariableExpr?
A variable generated from a FIELD_ACCESSOR_EXPRESSION is also displayed differently, e.g.,
 $$l.id.


https://asterix-gerrit.ics.uci.edu/#/c/1721/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java:

PS14, Line 34: "."
> Why switch to a hard-coded string?
It used to be File.pathSeparator, i.e., ":".  "." is only used once here.

dv.ds (rather than dv:ds) is what a user writes in the query.


https://asterix-gerrit.ics.uci.edu/#/c/1721/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ACollectionCursor.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ACollectionCursor.java:

Line 30:     @Override
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1721/14/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt8.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt8.java:

PS14, Line 59: Byte.toString(value);
> For this and the other number files: Should we still indicate the precision
Done


https://asterix-gerrit.ics.uci.edu/#/c/1721/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/ExternalFunctionInfo.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/ExternalFunctionInfo.java:

Line 27: public class ExternalFunctionInfo extends FunctionInfo implements IExternalFunctionInfo
{
> CRITICAL SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1721/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/FunctionDisplayUtil.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/FunctionDisplayUtil.java:

Line 32:     interface DefaultDisplayFunction {
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1721/1/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/functions/IFunctionInfo.java
File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/functions/IFunctionInfo.java:

Line 48:         sb.append(getFunctionIdentifier().getName() + "(");
> MAJOR SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1721
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91c15913009295352cf7cccf4a4028f1ff271e3f
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message