asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Make query plans more user-friendly.
Date Mon, 08 May 2017 19:01:30 GMT
Steven Jacobs has posted comments on this change.

Change subject: Make query plans more user-friendly.
......................................................................


Patch Set 14:

(3 comments)

Just a couple of small questions. It looks great overall.

https://asterix-gerrit.ics.uci.edu/#/c/1721/14/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TranslationContext.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TranslationContext.java:

PS14, Line 81: Expression
Why not require a VariableExpr?


https://asterix-gerrit.ics.uci.edu/#/c/1721/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java:

PS14, Line 34: "."
Why switch to a hard-coded string?


https://asterix-gerrit.ics.uci.edu/#/c/1721/14/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt8.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AInt8.java:

PS14, Line 59: Float.toString(value);
For this and the other number files: Should we still indicate the precision in some way?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1721
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91c15913009295352cf7cccf4a4028f1ff271e3f
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message