Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 23016200C61 for ; Tue, 11 Apr 2017 04:24:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2190C160BA5; Tue, 11 Apr 2017 02:24:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6904C160B99 for ; Tue, 11 Apr 2017 04:24:11 +0200 (CEST) Received: (qmail 42485 invoked by uid 500); 11 Apr 2017 02:24:10 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 42476 invoked by uid 99); 11 Apr 2017 02:24:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Apr 2017 02:24:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 268461A01CF for ; Tue, 11 Apr 2017 02:24:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.419 X-Spam-Level: * X-Spam-Status: No, score=1.419 tagged_above=-999 required=6.31 tests=[KAM_NUMSUBJECT=0.5, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id o0J3_ycJrx01 for ; Tue, 11 Apr 2017 02:24:06 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DF5425F1F4 for ; Tue, 11 Apr 2017 02:24:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 502F1240B6E; Mon, 10 Apr 2017 19:24:05 -0700 (PDT) Date: Mon, 10 Apr 2017 19:24:05 -0700 From: "Ian Maxon (Code Review)" Message-ID: Reply-To: imaxon@apache.org X-Gerrit-MessageType: newchange Subject: Change in asterixdb[master]: Fix for ASTERIXDB-1879 X-Gerrit-Change-Id: I63734838235e86ee9f0127663f73f65444c423bb X-Gerrit-ChangeURL: X-Gerrit-Commit: 495ef92c63cb0a791d11728675de8134e3ab1122 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 To: undisclosed-recipients:; archived-at: Tue, 11 Apr 2017 02:24:12 -0000 Ian Maxon has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1672 Change subject: Fix for ASTERIXDB-1879 ...................................................................... Fix for ASTERIXDB-1879 The issue was the filter was not persisted correctly for a number of reasons. Change-Id: I63734838235e86ee9f0127663f73f65444c423bb --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/frames/LSMComponentFilterReference.java 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/72/1672/1 diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/frames/LSMComponentFilterReference.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/frames/LSMComponentFilterReference.java index f04cbb0..5f2c36a 100644 --- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/frames/LSMComponentFilterReference.java +++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/frames/LSMComponentFilterReference.java @@ -103,13 +103,14 @@ } binaryFilter.setSize(binarySize); byte[] buf = binaryFilter.getByteArray(); - BooleanPointable.setBoolean(buf, MIN_SET_INDICATOR_OFFSET, min.getLength() == 0); - BooleanPointable.setBoolean(buf, MAX_SET_INDICATOR_OFFSET, max.getLength() == 0); + BooleanPointable.setBoolean(buf, MIN_SET_INDICATOR_OFFSET, min.getLength() > 0); + BooleanPointable.setBoolean(buf, MAX_SET_INDICATOR_OFFSET, max.getLength() > 0); int offset = 2; if (min.getLength() > 0) { IntegerPointable.setInteger(buf, offset, min.getLength()); offset += Integer.BYTES; System.arraycopy(min.getByteArray(), 0, buf, offset, min.getLength()); + offset += min.getLength(); } if (max.getLength() > 0) { IntegerPointable.setInteger(buf, offset, max.getLength()); @@ -127,6 +128,12 @@ @Override public int getLength() { + if(binaryFilter.getLength() <=0){ + if(isMinTupleSet() || isMaxTupleSet()) { + getByteArray(); + } + + } return binaryFilter.getLength(); } -- To view, visit https://asterix-gerrit.ics.uci.edu/1672 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I63734838235e86ee9f0127663f73f65444c423bb Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins