Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1081D200C59 for ; Mon, 17 Apr 2017 21:41:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0D778160BAB; Mon, 17 Apr 2017 19:41:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 55B62160B92 for ; Mon, 17 Apr 2017 21:41:14 +0200 (CEST) Received: (qmail 84777 invoked by uid 500); 17 Apr 2017 19:41:13 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 84768 invoked by uid 99); 17 Apr 2017 19:41:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Apr 2017 19:41:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 22AD918DCC3 for ; Mon, 17 Apr 2017 19:41:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id p_xdMFc-gHe8 for ; Mon, 17 Apr 2017 19:41:12 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EE9805FBBB for ; Mon, 17 Apr 2017 19:41:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 998B0240F7F; Mon, 17 Apr 2017 12:41:11 -0700 (PDT) Date: Mon, 17 Apr 2017 12:41:11 -0700 From: "Ian Maxon (Code Review)" To: abdullah alamoudi CC: Jenkins Reply-To: imaxon@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Remove Algebricks Pair and Triple X-Gerrit-Change-Id: I527df8df92e0323d2acc03d077be5c7503281a9d X-Gerrit-ChangeURL: X-Gerrit-Commit: 473dc0fbd310683a813d2487e16a1d5dd359b4cb In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20170417194111.998B0240F7F@unhygienix.ics.uci.edu> archived-at: Mon, 17 Apr 2017 19:41:15 -0000 Ian Maxon has posted comments on this change. Change subject: Remove Algebricks Pair and Triple ...................................................................... Patch Set 2: (1 comment) Why are we using mutablepair in some places and not others? What was the behavior of the original Pair? https://asterix-gerrit.ics.uci.edu/#/c/1689/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ConstantFoldingRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ConstantFoldingRule.java: PS2, Line 87: ImmutableSet.of(BuiltinFunctions.RECORD_MERGE, BuiltinFunctions.ADD_FIELDS, BuiltinFunctions.REMOVE_FIELDS, : BuiltinFunctions.GET_RECORD_FIELDS, BuiltinFunctions.GET_RECORD_FIELD_VALUE, : BuiltinFunctions.FIELD_ACCESS_NESTED, BuiltinFunctions.GET_ITEM, : BuiltinFunctions.OPEN_RECORD_CONSTRUCTOR, BuiltinFunctions.FIELD_ACCESS_BY_INDEX, : BuiltinFunctions.CAST_TYPE, BuiltinFunct whys this changed? -- To view, visit https://asterix-gerrit.ics.uci.edu/1689 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I527df8df92e0323d2acc03d077be5c7503281a9d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes