asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Make Index Op Contexts fields private
Date Sat, 29 Apr 2017 04:04:25 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Make Index Op Contexts fields private
......................................................................


Patch Set 1:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1712/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/PartitionedInMemoryInvertedIndex.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/PartitionedInMemoryInvertedIndex.java:

Line 135:             inMemListCursor.prepare(ctx.getBtreeAccessor(), ctx.getBtreePred(),
ctx.getTokenFieldsCmp(), ctx.getBtreeCmp());
> +1
Done


https://asterix-gerrit.ics.uci.edu/#/c/1712/1/hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTreeOpContext.java
File hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTreeOpContext.java:

Line 160:     public ArrayList<ICachedPage> getLSNUpdates() {
> +1
Done


Line 172:     public ArrayList<ICachedPage> getNSNUpdates() {
> +1
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1712
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message