asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xikui Wang (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Document the Query Service API
Date Mon, 24 Apr 2017 17:43:28 GMT
Xikui Wang has posted comments on this change.

Change subject: Document the Query Service API
......................................................................


Patch Set 1:

(2 comments)

I added two comments to the query handler id part. Is this the proper name for it?

https://asterix-gerrit.ics.uci.edu/#/c/1698/1/asterixdb/asterix-doc/src/site/markdown/api.md
File asterixdb/asterix-doc/src/site/markdown/api.md:

Line 157:     $ curl -v http://localhost:19002/query/service/status/9-0
> It should be completely opaque to the user - this is just something one get
How about put a short note to say this is based on the previous async command. The handle
id may vary on user side?


Line 182:     $ curl -v http://localhost:19002/query/service/result/7-0
> Same question/comment here.
How about append this section right after the deferred result delivery command and highlight
the handle id in the previous response and this request? This may help the readers realize
that these two numbers are used for identifying queries, which may help the status query as
well.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1698
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcefb1671ea305a5958c9a74a588b4aaa17f399f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message